Support newer Sylius and Symfony versions #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chirimoya
requested review from
wachterjohannes and
Prokyonn
and removed request for
a team
wachterjohannes
requested changes
Mar 27, 2023
|
|
||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| php: [7.4, 7.3] | ||
| php: [8.0, 8.1] |
There was a problem hiding this comment.
we should test 7.4 and 8.1
There was a problem hiding this comment.
In fact, we should change the required PHP version to ^8.0 as 7.4 is no longer supported in Sylius 1.11 💃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
As this bundle is already used by some projects, that are for sure upgrading to more modern Sylius and Symfony versions, I propose bumping the required Sylius version to 1.11+. Symfony can still stay on 4.4/5.4/6+, as these are versions supported by Sylius 1.11 and 1.12 combined :)
I've also simplified the build a little bit to make it work and reliable, but for sure it would be better to provide an actual test application to test the features of the plugin 🚀 🖖